-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to golangci-lint v1.32.0 #21
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The currently latest `golangci-lint` version 1.32.0 [1] introduced new linters that have been added to this template: 1. wrapcheck [2] — Checks that errors returned from external packages are wrapped. This linter is disabled by default, but has been enabled for this template to help tp reduce error context loss. 2. [errorlint][3] — Helps to make more efficient use of the error wrapping scheme introduced in Go 1.13. This linter is disabled by default, but has been enabled for this template to help to use Go's new error handling concept. 3. [tparallel][4] — Detects inappropriate usage of `t.Parallel()` method in Go tests. This linter is disabled by default, but has been enabled for this template to help to prevent parallelism errors in tests. [1]: https://github.com/golangci/golangci-lint/releases/tag/v1.32.0 [2]: https://github.com/tomarrell/wrapcheck [3]: https://github.com/polyfloyd/go-errorlint [4]: https://github.com/moricho/tparallel GH-20
svengreb
force-pushed
the
feature/gh-20-ugolangci-lint-version-1.32.0
branch
from
October 30, 2020 20:51
db5c880
to
4ba3beb
Compare
svengreb
added a commit
to svengreb/nib
that referenced
this pull request
Nov 11, 2020
Updated to `tmpl-go` version 0.5.0 [1] (including version 0.4.0 [2]) that... 1. ...introduces the initial project documentation [3]. 2. ...updates golangci-lint to the currently latest version 1.32.0 [4] which introduces new linters like errorlint [5], tparallel [6] and wrapcheck [7]. 3. ...updates to "tmpl" version 0.7.0 (GH-25 [8] GH-34 [9]). This includes... - ...a new configuration file for automated dependency updates and security alerts [10] with Dependabot [11]. Next to update configurations for the CI/CD GitHub action workflow [12] and Yarn/NPM dependencies [13], the file has been extended to support Go modules [14]. - ...updates to the latest Node.js package dependency & GitHub Action versions. - ...a change of the NPM package name to use a namespace [15] which helps to prevent collisions with already existing NPM packages like tmpl [16]. [1]: https://github.com/svengreb/tmpl-go/releases/tag/v0.5.0 [2]: https://github.com/svengreb/tmpl-go/releases/tag/v0.4.0 [3]: svengreb/tmpl-go#32 [4]: svengreb/tmpl-go#21 [5]: https://github.com/polyfloyd/go-errorlint [6]: https://github.com/moricho/tparallel [7]: https://github.com/tomarrell/wrapcheck [8]: svengreb/tmpl-go#25 [9]: svengreb/tmpl-go#34 [10]: svengreb/tmpl#52 [11]: https://dependabot.com [12]: https://github.com/svengreb/tmpl#cicd-action-workflow [13]: https://github.com/svengreb/tmpl#nodejs-yarn-and-npm [14]: https://golang.org/ref/mod [15]: svengreb/tmpl#48 [16]: https://www.npmjs.com/package/tmpl GH-25
svengreb
added a commit
to svengreb/nib
that referenced
this pull request
Nov 11, 2020
Updated to `tmpl-go` version 0.5.0 [1] (including version 0.4.0 [2]) that... 1. ...introduces the initial project documentation [3]. 2. ...updates golangci-lint to the currently latest version 1.32.0 [4] which introduces new linters like errorlint [5], tparallel [6] and wrapcheck [7]. 3. ...updates to "tmpl" version 0.7.0 (GH-25 [8] GH-34 [9]). This includes... - ...a new configuration file for automated dependency updates and security alerts [10] with Dependabot [11]. Next to update configurations for the CI/CD GitHub action workflow [12] and Yarn/NPM dependencies [13], the file has been extended to support Go modules [14]. - ...updates to the latest Node.js package dependency & GitHub Action versions. - ...a change of the NPM package name to use a namespace [15] which helps to prevent collisions with already existing NPM packages like tmpl [16]. [1]: https://github.com/svengreb/tmpl-go/releases/tag/v0.5.0 [2]: https://github.com/svengreb/tmpl-go/releases/tag/v0.4.0 [3]: svengreb/tmpl-go#32 [4]: svengreb/tmpl-go#21 [5]: https://github.com/polyfloyd/go-errorlint [6]: https://github.com/moricho/tparallel [7]: https://github.com/tomarrell/wrapcheck [8]: svengreb/tmpl-go#25 [9]: svengreb/tmpl-go#34 [10]: svengreb/tmpl#52 [11]: https://dependabot.com [12]: https://github.com/svengreb/tmpl#cicd-action-workflow [13]: https://github.com/svengreb/tmpl#nodejs-yarn-and-npm [14]: https://golang.org/ref/mod [15]: svengreb/tmpl#48 [16]: https://www.npmjs.com/package/tmpl Closes GH-25
svengreb
added a commit
to svengreb/nib
that referenced
this pull request
Nov 11, 2020
Updated to `tmpl-go` version 0.5.0 [1] (including version 0.4.0 [2]) that... 1. ...introduces the initial project documentation [3]. 2. ...updates golangci-lint to the currently latest version 1.32.0 [4] which introduces new linters like errorlint [5], tparallel [6] and wrapcheck [7]. 3. ...updates to "tmpl" version 0.7.0 (GH-25 [8] GH-34 [9]). This includes... - ...a new configuration file for automated dependency updates and security alerts [10] with Dependabot [11]. Next to update configurations for the CI/CD GitHub action workflow [12] and Yarn/NPM dependencies [13], the file has been extended to support Go modules [14]. - ...updates to the latest Node.js package dependency & GitHub Action versions. - ...a change of the NPM package name to use a namespace [15] which helps to prevent collisions with already existing NPM packages like tmpl [16]. [1]: https://github.com/svengreb/tmpl-go/releases/tag/v0.5.0 [2]: https://github.com/svengreb/tmpl-go/releases/tag/v0.4.0 [3]: svengreb/tmpl-go#32 [4]: svengreb/tmpl-go#21 [5]: https://github.com/polyfloyd/go-errorlint [6]: https://github.com/moricho/tparallel [7]: https://github.com/tomarrell/wrapcheck [8]: svengreb/tmpl-go#25 [9]: svengreb/tmpl-go#34 [10]: svengreb/tmpl#52 [11]: https://dependabot.com [12]: https://github.com/svengreb/tmpl#cicd-action-workflow [13]: https://github.com/svengreb/tmpl#nodejs-yarn-and-npm [14]: https://golang.org/ref/mod [15]: svengreb/tmpl#48 [16]: https://www.npmjs.com/package/tmpl Closes GH-25
svengreb
added a commit
to svengreb/wand
that referenced
this pull request
Nov 12, 2020
Updated to `tmpl-go` version 0.5.0 [1] (including version 0.4.0 [2]) that... 1. ...introduces the initial project documentation [3]. 2. ...updates golangci-lint to the currently latest version 1.32.0 [4] which introduces new linters like errorlint [5], tparallel [6] and wrapcheck [7]. 3. ...updates to "tmpl" version 0.7.0 (GH-25 [8] GH-34 [9]). This includes... - ...a new configuration file for automated dependency updates and security alerts [10] with Dependabot [11]. Next to update configurations for the CI/CD GitHub action workflow [12] and Yarn/NPM dependencies [13], the file has been extended to support Go modules [14]. - ...updates to the latest Node.js package dependency & GitHub Action versions. - ...a change of the NPM package name to use a namespace [15] which helps to prevent collisions with already existing NPM packages like tmpl [16]. [1]: https://github.com/svengreb/tmpl-go/releases/tag/v0.5.0 [2]: https://github.com/svengreb/tmpl-go/releases/tag/v0.4.0 [3]: svengreb/tmpl-go#32 [4]: svengreb/tmpl-go#21 [5]: https://github.com/polyfloyd/go-errorlint [6]: https://github.com/moricho/tparallel [7]: https://github.com/tomarrell/wrapcheck [8]: svengreb/tmpl-go#25 [9]: svengreb/tmpl-go#34 [10]: svengreb/tmpl#52 [11]: https://dependabot.com [12]: https://github.com/svengreb/tmpl#cicd-action-workflow [13]: https://github.com/svengreb/tmpl#nodejs-yarn-and-npm [14]: https://golang.org/ref/mod [15]: svengreb/tmpl#48 [16]: https://www.npmjs.com/package/tmpl GH-4
svengreb
added a commit
to svengreb/wand
that referenced
this pull request
Nov 12, 2020
Updated to `tmpl-go` version 0.5.0 [1] (including version 0.4.0 [2]) that... 1. ...introduces the initial project documentation [3]. 2. ...updates golangci-lint to the currently latest version 1.32.0 [4] which introduces new linters like errorlint [5], tparallel [6] and wrapcheck [7]. 3. ...updates to "tmpl" version 0.7.0 (GH-25 [8] GH-34 [9]). This includes... - ...a new configuration file for automated dependency updates and security alerts [10] with Dependabot [11]. Next to update configurations for the CI/CD GitHub action workflow [12] and Yarn/NPM dependencies [13], the file has been extended to support Go modules [14]. - ...updates to the latest Node.js package dependency & GitHub Action versions. - ...a change of the NPM package name to use a namespace [15] which helps to prevent collisions with already existing NPM packages like tmpl [16]. [1]: https://github.com/svengreb/tmpl-go/releases/tag/v0.5.0 [2]: https://github.com/svengreb/tmpl-go/releases/tag/v0.4.0 [3]: svengreb/tmpl-go#32 [4]: svengreb/tmpl-go#21 [5]: https://github.com/polyfloyd/go-errorlint [6]: https://github.com/moricho/tparallel [7]: https://github.com/tomarrell/wrapcheck [8]: svengreb/tmpl-go#25 [9]: svengreb/tmpl-go#34 [10]: svengreb/tmpl#52 [11]: https://dependabot.com [12]: https://github.com/svengreb/tmpl#cicd-action-workflow [13]: https://github.com/svengreb/tmpl#nodejs-yarn-and-npm [14]: https://golang.org/ref/mod [15]: svengreb/tmpl#48 [16]: https://www.npmjs.com/package/tmpl Closes GH-4
svengreb
added a commit
to svengreb/wand
that referenced
this pull request
Nov 12, 2020
Updated to `tmpl-go` version 0.5.0 [1] (including version 0.4.0 [2]) that... 1. ...introduces the initial project documentation [3]. 2. ...updates golangci-lint to the currently latest version 1.32.0 [4] which introduces new linters like errorlint [5], tparallel [6] and wrapcheck [7]. 3. ...updates to "tmpl" version 0.7.0 (GH-25 [8] GH-34 [9]). This includes... - ...a new configuration file for automated dependency updates and security alerts [10] with Dependabot [11]. Next to update configurations for the CI/CD GitHub action workflow [12] and Yarn/NPM dependencies [13], the file has been extended to support Go modules [14]. - ...updates to the latest Node.js package dependency & GitHub Action versions. - ...a change of the NPM package name to use a namespace [15] which helps to prevent collisions with already existing NPM packages like tmpl [16]. [1]: https://github.com/svengreb/tmpl-go/releases/tag/v0.5.0 [2]: https://github.com/svengreb/tmpl-go/releases/tag/v0.4.0 [3]: svengreb/tmpl-go#32 [4]: svengreb/tmpl-go#21 [5]: https://github.com/polyfloyd/go-errorlint [6]: https://github.com/moricho/tparallel [7]: https://github.com/tomarrell/wrapcheck [8]: svengreb/tmpl-go#25 [9]: svengreb/tmpl-go#34 [10]: svengreb/tmpl#52 [11]: https://dependabot.com [12]: https://github.com/svengreb/tmpl#cicd-action-workflow [13]: https://github.com/svengreb/tmpl#nodejs-yarn-and-npm [14]: https://golang.org/ref/mod [15]: svengreb/tmpl#48 [16]: https://www.npmjs.com/package/tmpl Closes GH-4
svengreb
added a commit
that referenced
this pull request
Nov 16, 2020
In GH-21 [1] "golangci-lint" was updated to the currently latest version 1.32.0 [2] which introduced the errorlint [3] that has been enabled for this template repository. As it turns out it causes a lot of false-positives errors for code lines that explicitly do not wrap the error to prevent it become part of the public API. Therefore the linter has been disabled again because the update also introduced the new wrapcheck [4] linter which helps to prevent that errors from external packages are exposed to the public API. [1]: #21 [2]: https://github.com/golangci/golangci-lint/releases/tag/v1.32.0 [3]: https://github.com/polyfloyd/go-errorlint [4]: https://github.com/tomarrell/wrapcheck GH-39
svengreb
added a commit
that referenced
this pull request
Nov 16, 2020
In GH-21 [1] "golangci-lint" was updated to the currently latest version 1.32.0 [2] which introduced the errorlint [3] that has been enabled for this template repository. As it turns out it causes a lot of false-positives errors for code lines that explicitly do not wrap the error to prevent it become part of the public API. Therefore the linter has been disabled again because the update also introduced the new wrapcheck [4] linter which helps to prevent that errors from external packages are exposed to the public API. [1]: #21 [2]: https://github.com/golangci/golangci-lint/releases/tag/v1.32.0 [3]: https://github.com/polyfloyd/go-errorlint [4]: https://github.com/tomarrell/wrapcheck Closes GH-39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #20