Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant GitHub Action workflow job for tests in Windows #13

Merged

Conversation

svengreb
Copy link
Owner

Resolves #12

There are currently no OS specific tests so the `test` workflow job
now only runs on Linux. The additional run on "Windows" was unnecessary
and only wasted build minutes because each minute is calculated 2x when
running on "Windows". See the section about "Minute multipliers" in the
official GitHub Action Pricing documentation [1].

Next to this it also helps to improve the performance since workflows
running on "Windows" are currently taking the most time.

[1]: https://docs.github.com/en/free-pro-team@latest/github/setting-up-and-managing-billing-and-payments-on-github/about-billing-for-github-actions

GH-12
@svengreb svengreb added this to the 0.1.0 milestone Nov 16, 2020
@svengreb svengreb self-assigned this Nov 16, 2020
@svengreb svengreb merged commit 5d41725 into main Nov 16, 2020
@svengreb svengreb deleted the improvement/gh-12-remove-redundant-workflow-test-windows branch November 16, 2020 14:33
@svengreb svengreb removed their assignment Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove redundant GitHub Action workflow job for tests in Windows
1 participant