-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding --remove-mustaches using pystache (new feature #23) #24
Conversation
What do you think of this idea ? :) |
This sounds like a preprocessor to convert mustache templates to HTML. Its I could see adding a crawler. That would mean you could serve HTML On Mon, Jul 25, 2016 at 6:43 PM Lucas Cimon notifications@github.com
|
I don't get the crawler role here. What transformation would it perform on its input exactly ? And what kind of input would it take ? But I understand your point about the separation of concerns & mustache templates beeing too specific. There are many flavours of HTML templating systems. Just to name a few:
Certainly there is a need for extensibility here, and there is no reason to support only mustache templates. However, I do not not really agree that this is clearly out of the scope of a Python lib / CLI HTML validator. Of course, you may not want your validator to take this direction. It's your call, and I can build another tool or fork |
Any thoughts ? |
I was thinking more about something like localcrawl. This can crawl a local development server and it processes all the JavaScript with a headless browser. It outputs the generated HTML and works with any template engine. The readme contains an example with a small Mustache template. Does that work for your use case? |
I worked around this by implementing mustaches-substitution in my pre-commit hook: No, Closing this |
No description provided.