Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #86 #87

Merged
merged 2 commits into from
Jul 7, 2021
Merged

Fix #86 #87

merged 2 commits into from
Jul 7, 2021

Conversation

jamesjuett
Copy link
Contributor

This PR fixes #86.

Since Python 3.7, os.errno is no longer available.

@svenkreiss
Copy link
Owner

Thanks @jamesjuett . Do you have a reference for that?
It seems, in practice, os.errno still works because our tests are passing.

@jamesjuett
Copy link
Contributor Author

Fair question! I've tracked down an authoritative source:

https://github.com/python/cpython/blob/main/Doc/whatsnew/3.7.rst#changes-in-the-python-api

(Near the bottom of the list, or just search for "errno".)

@svenkreiss
Copy link
Owner

Thanks for that reference. If you can fix the lint error (import order) then this is good to go.

@jamesjuett
Copy link
Contributor Author

Ah yeah, my bad on the import ordering - fixed!

(Note on the force push...I'm on WSL and have issues with clock drift when my machine hibernates. The force push was after I realized my commit to fix the lint issue was showing up as several days ago.)

@svenkreiss
Copy link
Owner

Awesome. Thanks for the fix!

@svenkreiss svenkreiss merged commit be544f0 into svenkreiss:main Jul 7, 2021
@jamesjuett jamesjuett deleted the 86-fix-errno branch July 7, 2021 19:20
yous added a commit to yous/yous.be that referenced this pull request Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: module 'os' has no attribute 'errno'
2 participants