Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/sql types alt #102

Merged
merged 3 commits into from
May 1, 2020
Merged

Conversation

tools4origins
Copy link
Collaborator

Same as #97 but with a rewritten history, it's on top of #101 which is on top of #100, reviewing them in order is probably much easier:

This PR:

  • Introduce Spark SQL types
  • Introduce SQL-related exceptions
  • Adds a python_to_spark_type function which maps a python type to its spark counterpart

@stale
Copy link

stale bot commented Apr 16, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 16, 2020
@svenkreiss svenkreiss removed the stale label Apr 16, 2020
svenkreiss
svenkreiss previously approved these changes Apr 16, 2020
@tools4origins
Copy link
Collaborator Author

tools4origins commented May 1, 2020

Added 2 commits:

  • 1 that seems to fix a transient issue in multithreading tests, which seems to have been caused by too many thread/executor pools creations with regard to Travis CI machine resources (I was able to reproduce it on my laptop by increasing the pool size).
  • 1 that explicit that a new pylint warning is not relevant

Travis is green :) https://travis-ci.org/github/svenkreiss/pysparkling/builds/681921094

Do you think we could set pylint version in setup.py so that we don't have those new warnings appearing in unrelated code modifications?

PS: Added a rebase

Copy link
Owner

@svenkreiss svenkreiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Also thanks for fixing the multiprocessing pool tests!

About fixing pylint version: I am open to that. I would be against getting too far behind so if the pylint version is fixed, it should still be updated from time to time, but that could be done in a PR that does just that.

@svenkreiss svenkreiss merged commit 2312f41 into svenkreiss:master May 1, 2020
tools4origins pushed a commit to tools4origins/pysparkling that referenced this pull request May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants