-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/sql types alt #102
Feat/sql types alt #102
Conversation
4bb000e
to
9d77ee5
Compare
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Added 2 commits:
Travis is green :) https://travis-ci.org/github/svenkreiss/pysparkling/builds/681921094 Do you think we could set pylint version in setup.py so that we don't have those new warnings appearing in unrelated code modifications? PS: Added a rebase |
(cherry picked from commit 1e6ad47)
badb0ad
to
6d2a3f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. Also thanks for fixing the multiprocessing pool tests!
About fixing pylint version: I am open to that. I would be against getting too far behind so if the pylint version is fixed, it should still be updated from time to time, but that could be done in a PR that does just that.
Feat/sql types alt
Same as #97 but with a rewritten history, it's on top of #101 which is on top of #100, reviewing them in order is probably much easier:
This PR: