Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding scripts to the checkings #147

Merged
merged 7 commits into from
Jan 30, 2021
Merged

Adding scripts to the checkings #147

merged 7 commits into from
Jan 30, 2021

Conversation

svaningelgem
Copy link
Contributor

As mentioned in the other PR, I added the scripts to be checked as well + fixed the issues that came up during these checks.

svenkreiss
svenkreiss previously approved these changes Jan 29, 2021
Copy link
Owner

@svenkreiss svenkreiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again! This looks good. Just a minor comment. Feel free to squash and merge yourself.

scripts/tcpperf_server.py Outdated Show resolved Hide resolved
import csv
from collections import namedtuple
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer if these stayed in alphabetical order.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pylint or pycodestyle was complaining about this in python 3.9 if I'm not mistaken...

@svaningelgem
Copy link
Contributor Author

Thanks again! This looks good. Just a minor comment. Feel free to squash and merge yourself.

"Only those with write access to this repository can merge pull requests."

@svenkreiss
Copy link
Owner

Thanks!

@svenkreiss svenkreiss merged commit 8672268 into svenkreiss:master Jan 30, 2021
@svaningelgem svaningelgem deleted the Adding_scripts_to_the_checkings branch January 30, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants