-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/untangling imports #161
Closed
svaningelgem
wants to merge
11
commits into
svenkreiss:master
from
svaningelgem:feat/untangling_imports
Closed
Feat/untangling imports #161
svaningelgem
wants to merge
11
commits into
svenkreiss:master
from
svaningelgem:feat/untangling_imports
Commits on Mar 1, 2021
-
- change of name from `stat_counter.py` to `statcounter.py` as that's the name in pyspark. - Moved as much as I could into 'terminals'. Meaning modules which are _not_ depending on any others except for externals to pysparkling. There's still a lot to do here! - Moved stuff out from pysparkling into pysparkling.sql because the SQL code just does not belong in the root! - The most glaring example of this is the method `toDF` which is moved to sql.session.py and is being monkey-patched. Just like pyspark is doing it. (don't re-invent the wheel :)). - Moved stuff to private (to pysparkling) modules (modules starting with `_`) which are not defined in pyspark. This helped to reduce the complexity a lot.
Configuration menu - View commit details
-
Copy full SHA for ac6a161 - Browse repository at this point
Copy the full SHA ac6a161View commit details -
- change of name from `stat_counter.py` to `statcounter.py` as that's the name in pyspark. - Moved as much as I could into 'terminals'. Meaning modules which are _not_ depending on any others except for externals to pysparkling. There's still a lot to do here! - Moved stuff out from pysparkling into pysparkling.sql because the SQL code just does not belong in the root! - The most glaring example of this is the method `toDF` which is moved to sql.session.py and is being monkey-patched. Just like pyspark is doing it. (don't re-invent the wheel :)). - Moved stuff to private (to pysparkling) modules (modules starting with `_`) which are not defined in pyspark. This helped to reduce the complexity a lot.
Configuration menu - View commit details
-
Copy full SHA for 4ee7d8e - Browse repository at this point
Copy the full SHA 4ee7d8eView commit details -
- renamed schema_utils to _schema_utils (as it's an internal module).
- Added a script to compare pyspark & pysparkling to see what still needs to be implemented.
Configuration menu - View commit details
-
Copy full SHA for 60c74d9 - Browse repository at this point
Copy the full SHA 60c74d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for b0ed5a4 - Browse repository at this point
Copy the full SHA b0ed5a4View commit details
Commits on Mar 2, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 29a7d99 - Browse repository at this point
Copy the full SHA 29a7d99View commit details -
Configuration menu - View commit details
-
Copy full SHA for cef2e7c - Browse repository at this point
Copy the full SHA cef2e7cView commit details
Commits on Mar 3, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 1597c72 - Browse repository at this point
Copy the full SHA 1597c72View commit details -
Configuration menu - View commit details
-
Copy full SHA for df4b505 - Browse repository at this point
Copy the full SHA df4b505View commit details -
Created a reverse auto injector too. This will be very helpful for co…
…mparing test-runs.
Configuration menu - View commit details
-
Copy full SHA for bb4a3ab - Browse repository at this point
Copy the full SHA bb4a3abView commit details -
Configuration menu - View commit details
-
Copy full SHA for f3349ff - Browse repository at this point
Copy the full SHA f3349ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d7cae6 - Browse repository at this point
Copy the full SHA 2d7cae6View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.