Add footer with program version #456
Conversation
src/renderer.rs
Outdated
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // Get version info | ||
| fn get_version_info() -> String { | ||
| const PROG_NAME: Option<&'static str> = option_env!("CARGO_PKG_NAME"); |
There was a problem hiding this comment.
Small nit: You can use crate_version!() and crate_name!() from clap (which is re-exported from structopt which we already use). This should cut down on the code a little.
src/renderer.rs
Outdated
| // Partial: version footer | ||
| fn version_footer() -> Markup { | ||
| html! { | ||
| p style="text-align:center;padding-top:1em" { |
There was a problem hiding this comment.
Let's make this a little less visible. I suggest making it smaller and giving it a somewhat succinct color (depending on theme).
The at_color in style.scss seems like a good candidate to build off of. I suggest make a new variable footer_color in every theme, use the respective values of at_color and just tone down the contrast a little.
|
Oh, and you can tell clippy to ignore the complexity for that function that's failing. |
|
Thanks for your comments, @svenstaro. I managed to address them. Could you please take another look? |
|
Great stuff, thanks! :) |
Implements #336. Looks super basic. Comments, edits, etc. are welcome.
Directory Listing:
An Error Page: