Allow custom route prefix #534
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and rewrite {save_file, handle_multipart}
... and fix clippy warning about create_error_response() being always Ok()
|
Tests will be implemented as test cases for the test in #500 once merged |
|
Should |
... page rendering Too many arguments are moved around and many of them are already stored in MiniserveConfig. Many of these are used to render error pages. To fix this issue, it was necessary to rework error page rendering: 1. Implement `ResponseError` for `ContextualError` so that it can be returned from service handlers as is and will then be automatically logged to the console and converted into an error response. 2. At service handler level, all error responses are now rendered as plain text. 3. 'error_page_middleware' is now responsible for the rendering of the final error page from plain text reponses. Signed-off-by: Ali MJ Al-Nasrawy <alimjalnasrawy@gmail.com>
Signed-off-by: Ali MJ Al-Nasrawy <alimjalnasrawy@gmail.com>
Less code and more readable; Use scopes for random route Signed-off-by: Ali MJ Al-Nasrawy <alimjalnasrawy@gmail.com>
Signe-off-by: Ali MJ Al-Nasrawy <alimjalnasrawy@gmail.com>
Signed-off-by: Ali MJ Al-Nasrawy <alimjalnasrawy@gmail.com>
|
I have opened a PR to @aliemjay's repo to fix merge conflicts here. Also fixes loading of CSS and favicon when behind a route prefix. See: aliemjay#1 |
Fix merge conflicts.
|
Closing in favor of #579 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup for #208
Based on #537
Closes #533
Closes #208