[Refactor] Miscellaneous small refactors #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance you could produce separate PRs? It'd make review quite a bit cleaner for me and I promise to review/merge them quickly. :) |
Signe-off-by: Ali MJ Al-Nasrawy <alimjalnasrawy@gmail.com>
Signed-off-by: Ali MJ Al-Nasrawy <alimjalnasrawy@gmail.com>
aliemjay
force-pushed
the
src-refactor-misc
branch
from
35d471a
to
3c80cc1
Compare
|
@svenstaro these are now REALLY small :) |
|
Got more refactors coming in building on top of this? |
Not for now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do they need separate PRs?
Please see individual commits.
Based on #529.