Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude patterns exclude more than expected #80

Closed
sverweij opened this issue Dec 6, 2018 · 2 comments · Fixed by #81
Closed

exclude patterns exclude more than expected #80

sverweij opened this issue Dec 6, 2018 · 2 comments · Fixed by #81
Assignees
Labels
bug something is not working as expected
Projects

Comments

@sverweij
Copy link
Owner

sverweij commented Dec 6, 2018

Expected Behavior

passing an exclude pattern only exludes modules matching that pattern

Current Behavior

orphans (and maybe other modules?) don't show up in the output

Steps to Reproduce (for bugs)

depcruise -T dot src | dot -T png -Gdpi=192 > fixture.png

result:
fixture

Adding an exclude parameter e.g. like this

depcruise --exclude "^[a-z]+$" -T dot src | dot -T png -Gdpi=192 > less
.png

yields not only the exclusion of /^[a-z]+$/, but also of the orphans that are left after excluding:
less

Context

see #61

Your Environment

  • Version used: 4.7.0
  • Node version: 10
  • Operating System and version: NR
@sverweij sverweij changed the title exclude patterns seem to exclude more than expected exclude patterns exclude more than expected Dec 6, 2018
sverweij added a commit that referenced this issue Dec 6, 2018
@sverweij
Copy link
Owner Author

sverweij commented Dec 6, 2018

@OlegAlexander as you can see above I'm working on it . There is a beta version on npm that includes a fix - you can already try it out if you're on linux or OSX/macOS regardless of your platform (dependency-cruiser@4.7.1-beta-0).

As far as I can see it's a correct fix, but let me know if it still behaves unexpectedly for you!

@sverweij sverweij added this to backlog in roadmap via automation Dec 6, 2018
@sverweij sverweij moved this from backlog to doing in roadmap Dec 6, 2018
@sverweij sverweij self-assigned this Dec 6, 2018
@sverweij sverweij added the bug something is not working as expected label Dec 6, 2018
@OlegAlexander
Copy link

I have tested dependency-cruiser@4.7.1-beta-0 on Windows 10 and can confirm that it's doing the right thing now. Thank you so much for fixing this issue so quickly!

roadmap automation moved this from doing to done Dec 7, 2018
@sverweij sverweij moved this from done to released in roadmap Dec 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something is not working as expected
Projects
Status: released
roadmap
  
released
Development

Successfully merging a pull request may close this issue.

2 participants