Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): set-up github action #84

Merged
merged 1 commit into from
Oct 7, 2019
Merged

feat(ci): set-up github action #84

merged 1 commit into from
Oct 7, 2019

Conversation

Lp-Francois
Copy link
Contributor

Plan to do something drastic?
Leave an issue with a
summary of the changes you propose + some context on why you'd want to
do that.

Description

Add main.yml file for github action.

Instead of lastest, there is 12.x version for Nodejs.

It follows sverweij/dependency-cruiser#197.

The npm run check command means run-p --aggregate-output depcruise lint test:cover, which cover the commands executed in the gitlab-ci.yml file.

Motivation and Context

Related to this issue #83

How Has This Been Tested?

No tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • The code I add will be subject to The MIT license, and I'm OK with that.
  • The code I've added is my own original work.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codeclimate
Copy link

codeclimate bot commented Oct 7, 2019

Code Climate has analyzed commit e6937b8 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

@sverweij
Copy link
Owner

sverweij commented Oct 7, 2019

Merci beaucoup!

@sverweij sverweij merged commit 4acbacf into sverweij:develop Oct 7, 2019
@sverweij sverweij mentioned this pull request Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants