-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change SvgSymbol namespace. #556
Conversation
|
||
namespace Svg.Document_Structure | ||
namespace Svg.DocumentStructure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I understand that this namespace fits better into the naming schema, but are you duplicating the whole class for this? I'm not sure that it is worth it...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Svg.Document_Structure.SvgSymbol
will be removed.
So I added Obsolete
.
Also referring this to @tebjan - I'm unsure about the policy here. |
55d5c65
to
7de872a
Compare
I'm not happy with this duplicated code just for the sake of a more convenient namespace name. If there were a way to just add an alias to the namespace it would be ok. As far as I know, a namespace alias can only be used on import and cannot be exported, but hopefully someone knows a better possibility? |
4c6ccfc
to
9e2ca3c
Compare
|
rebase master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this better, thanks! Can you add an entry in the release notes for the changed API?
I wrote the following in this PR:
But, still do not need this namespace, so I decided to remove it in this commit. using Svg.Document_Structure;
...
var symbol = new SvgSymbol // error. but ok if Svg.Document_Structure.SvgSymbol
{
Fill = new SvgColourServer(Color.Red),
Stroke = new SvgColourServer(Color.Black),
StrokeWidth = 2
}; However, I think this error would make users aware of the change.(It's easy to fix.) |
While this looks ok to me, I'm still a bit unsure about the consequences to users. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to merge this now, I think it is ok as is.
…md Generators Nuget README.md Samples Source Tests doc docfx.json index.md license.txt Change SvgSymbol namespace from Svg.Document_Structure to Svg BuildProcessTemplates CONTRIBUTING.md Generators Nuget README.md Samples Source Tests doc docfx.json index.md license.txt Add compatibilty wrapper with old namespace
Reference Issue
ref. #93.
What does this implement/fix? Explain your changes.
Only
Svg.Document_Structure
, _(underscore) is included in namespace.So, change namespace without _(underscore).
I think
Svg.Symbol
is good.(likeSvgDefinitionList
,SvgFragment
andSvgGroup
.)However, because there is a possibility of build error in existing environments, I decided on this namespace.
Any other comments?