Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new line joins defined by the SVG standard #621

Merged
merged 2 commits into from Dec 27, 2020
Merged

Add new line joins defined by the SVG standard #621

merged 2 commits into from Dec 27, 2020

Conversation

JoaoBaptMG
Copy link
Contributor

What does this implement/fix? Explain your changes.

This pull request adds support for two new line joins defined by the SVG standard as stated here: miter-clip and arcs.

Any other comments?

The SVG WG documentation stated that those line joins are at risk because there is no browser implementation for it. I added support for them in my project of svg renderer, so I would like to have support for them in the SVG loader.

@mrbean-bremen
Copy link
Member

@JoaoBaptMG - thanks, this looks good to me! Do you have a simple example image to add to the test suite (e.g. SVG + PNG)?
@H1Gdev - can you have another look at the PR please?

@mrbean-bremen
Copy link
Member

@H1Gdev , @wieslawsoltes - can one of you have another look? It seems to be good to merge to me.

@JoaoBaptMG
Copy link
Contributor Author

JoaoBaptMG commented May 9, 2020

I am really sorry for not having responded before. The arcs is not really supported by GDI+, so it’s not really possible to test. It was added just because I am using this library to load SVG on my GPU vector rendering library or at least I was before scrapping it.

@H1Gdev
Copy link
Contributor

H1Gdev commented May 10, 2020

@mrbean-bremen

miter-clip, arcs and fr are SVG2 specifications.
How do we implement SVG2 ?

@mrbean-bremen
Copy link
Member

How do we implement SVG2 ?

We have a few things from SVG2 already in (don't remember which ones right now), and while we won't advertise it (yet), we could add the support incrementally where needed.
The only problematic cases would be actual changes in behavior between 1.1 to 2 (instead of added new features), but we can address these later as needed.

@mrbean-bremen
Copy link
Member

I'm going to merge this - we can add it to the release notes afterwards.

@mrbean-bremen mrbean-bremen merged commit 9850ed3 into svg-net:master Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants