Add option --quiet #445
Merged
Add option --quiet #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I trust that svgo works, and the output of my build process is overly long as it is. Add a -q/--quiet option to suppress all the chatter and only show important / error messages.
|
@GreLI Is there something wrong with this pull request? Any opinion? |
|
Just forgot it. |
| @@ -295,9 +304,11 @@ function optimizeFromString(svgstr, config, datauri, input, output) { | |||
| output = input; | |||
| } | |||
|
|
|||
| console.log('\r'); | |||
| if (! config.quiet) { | |||
There was a problem hiding this comment.
Also, this space after “!” doesn't fit the codestyle.
There was a problem hiding this comment.
Thanks, I have updated my pull request with a fix. Is there any way to check for style inconsistencies with this project? I found a jshint configuration file and ran jshint, but it did not report anything.
There was a problem hiding this comment.
There are several places and this is only one of those. You have updated in some other place.
There was a problem hiding this comment.
Oops, I apologize. I have made sure that the source code does not contain /!\s+/ anymore.
|
Nice. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I trust that svgo works, and the output of my build process is overly long as it is. Add a
-q/--quietoption to suppress all the chatter and only show important / error messages.