Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix basetag bug #663

Closed
wants to merge 18 commits into from
Closed

Fix basetag bug #663

wants to merge 18 commits into from

Conversation

Fuzzyma
Copy link
Member

@Fuzzyma Fuzzyma commented Apr 23, 2017

prefix all url() references with current location (#568)

the prefix is removed on export and added on import.

TODO:

  • add tests when exporting svg which alrady has a location in fill set e.g. fill="url(google.de/some.svg# someId)" and the same when importing
  • compare performance (which is most likely reduced when importing/exporting svgs)

- removed `SVG.Array.split()` function (#604)
- removed workaround for browser bug with stroke-width (#560)
- removed polyfills
- removed `ungroup()` in favour of `flatten()`
- gradients now have their corresponding nodename as type and not only radial/linear (#606)
- `SVG.Path.pointAt()` correctly returns an `SVG.Point` now (#607)
- replaced static reference to `masker` in `SVG.Mask` with the `masker()` method
- replaced static reference to `clipper` in `SVG.ClipPath` with the `clipper()` method
- replaced static reference to `targets` in `SVG.Mask` and `SVG.ClipPath` with the `targets()` method (all three #563)
unified all boxes

- SVG.Box for everything
- bbox, rbox and viewbox as methods
- boxes can be created with string, array, object, list...
- added helper to simplify boxes code
Conflicts (all resolved):
	dist/svg.js
	dist/svg.min.js
	spec/spec/boxes.js
SVG.Image is now constructed with:
- container.image(src, callback)
- new SVG.Image().load(src, callback)
# Conflicts - all resolved:
#	dist/svg.js
#	dist/svg.min.js
#	package.json
#	spec/SpecRunner.html
#	spec/spec/boxes.js
#	spec/spec/element.js
#	spec/spec/image.js
#	spec/spec/svg.js
#	src/boxes.js
#	src/flatten.js
#	src/image.js
#	src/polyfill.js
#	src/style.js
#	src/svg.js
it now accepts array as input and returns object when no argument given (#517)
also removed sub-pixel offset fix
Instead they are generated when requested (#559)
the prefix is removed on export and added on import
@Fuzzyma Fuzzyma closed this Apr 23, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 98.829% when pulling 86f2910 on fix-basetag-bug into 04e21b1 on master.

@Fuzzyma
Copy link
Member Author

Fuzzyma commented Apr 23, 2017

sry guys - wrong base branch. Opened another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants