Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ollama chat #41

Merged
merged 10 commits into from
Dec 24, 2023
Merged

Add Ollama chat #41

merged 10 commits into from
Dec 24, 2023

Conversation

svilupp
Copy link
Owner

@svilupp svilupp commented Dec 24, 2023

Created a new default schema for Ollama models OllamaSchema (replacing OllamaManagedSchema), which allows multi-turn conversations and conversations with images (eg, with Llava and Bakllava models). OllamaManagedSchema has been kept for compatibility and as an example of a schema where one provides prompt as a string (not dictionaries like OpenAI API)

Copy link

codecov bot commented Dec 24, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (cc30588) 92.49% compared to head (f39cfdc) 93.55%.

Files Patch % Lines
src/llm_ollama.jl 94.00% 3 Missing ⚠️
src/llm_ollama_managed.jl 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
+ Coverage   92.49%   93.55%   +1.06%     
==========================================
  Files          23       24       +1     
  Lines        1092     1148      +56     
==========================================
+ Hits         1010     1074      +64     
+ Misses         82       74       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svilupp svilupp merged commit 227c213 into main Dec 24, 2023
4 checks passed
@svilupp svilupp deleted the add-ollama-chat branch December 24, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant