Skip to content

Commit

Permalink
Fix warnings for 1.8 and 1.9
Browse files Browse the repository at this point in the history
  • Loading branch information
drbrain committed Aug 26, 2011
1 parent 81a6f40 commit 10d5ba8
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 4 deletions.
2 changes: 1 addition & 1 deletion lib/rubygems/commands/owner_command.rb
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def manage_owners method, name, owners
end

with_response response
rescue => e
rescue
# ignore
end
end
Expand Down
2 changes: 1 addition & 1 deletion test/rubygems/test_gem_commands_install_command.rb
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ def test_execute_conflicting_install_options
@cmd.options[:install_dir] = "whatever"

use_ui @ui do
e = assert_raises Gem::MockGemUi::TermError do
assert_raises Gem::MockGemUi::TermError do
@cmd.execute
end
end
Expand Down
8 changes: 6 additions & 2 deletions test/rubygems/test_gem_specification.rb
Original file line number Diff line number Diff line change
Expand Up @@ -151,13 +151,17 @@ def test_self_from_yaml_syck_default_key_bug
type: :development
prerelease: false
version_requirements: *70243867725240
platform: ruby
files: []
test_files: []
bindir:
YAML

new_spec = with_syck do
Gem::Specification.from_yaml yaml
end

refute_match /DefaultKey/, new_spec.to_ruby
refute_match %r%DefaultKey%, new_spec.to_ruby
end

def test_self_load
Expand Down Expand Up @@ -1023,7 +1027,7 @@ def test_to_ruby_nested_hash

ruby = @a2.to_ruby

assert_match /^ s\.metadata = { "/, ruby
assert_match %r%^ s\.metadata = \{ "%, ruby
end

def test_to_ruby_platform
Expand Down

0 comments on commit 10d5ba8

Please sign in to comment.