Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/discovery #149

Merged
merged 3 commits into from
Jan 2, 2022
Merged

Feature/discovery #149

merged 3 commits into from
Jan 2, 2022

Conversation

svrooij
Copy link
Owner

@svrooij svrooij commented Dec 16, 2021

Device discovery

Description

The Device discovery wasn't working on windows. With these changes it should be much more stable.

Your checklist for this pull request

🚨 Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the beta branch (left side). Also you should start your branch off svrooij/node-sonos-ts/beta.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.
  • Check you add tests for added code.

💔 Thank you!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1587999058

  • 30 of 33 (90.91%) changed or added relevant lines in 2 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+1.5%) to 78.081%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/sonos-event-listener.ts 4 5 80.0%
src/sonos-device-discovery.ts 26 28 92.86%
Files with Coverage Reduction New Missed Lines %
src/sonos-device-discovery.ts 1 87.1%
src/sonos-event-listener.ts 5 74.57%
Totals Coverage Status
Change from base Build 1586640595: 1.5%
Covered Lines: 1530
Relevant Lines: 1938

💛 - Coveralls

@svrooij svrooij linked an issue Jan 2, 2022 that may be closed by this pull request
3 tasks
@svrooij svrooij merged commit 7c34ed7 into beta Jan 2, 2022
@svrooij svrooij deleted the feature/discovery branch January 2, 2022 10:05
@github-actions
Copy link

github-actions bot commented Jan 2, 2022

🎉 This PR is included in version 2.5.0-beta.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 2.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Discovery not working (for symfonic speaker)
2 participants