Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(project CreateBom): decode multiple purls and warn user #37

Merged
merged 1 commit into from
Aug 26, 2023

Conversation

gernot-h
Copy link
Collaborator

@gernot-h gernot-h commented Aug 19, 2023

When creating an SBOM from a SW360 project, add all to the SBOM separated by spaces, but warn the user to manually fix the SBOM.

This is still a draft as it lacks a testcase.

Fixes #36

@tngraf
Copy link
Collaborator

tngraf commented Aug 19, 2023

Yes, we missed such a check before... got for it.

@gernot-h gernot-h force-pushed the fix-project-createbom-multiple-purl branch from acc0e6d to 8cecd12 Compare August 21, 2023 12:09
@gernot-h gernot-h marked this pull request as ready for review August 21, 2023 12:30
@gernot-h
Copy link
Collaborator Author

Test case added, so from my side, it's ready for review/merging. Let me know what you think about adding all purls and warning the user this way.

@tngraf tngraf merged commit cae3746 into main Aug 26, 2023
5 checks passed
@gernot-h gernot-h deleted the fix-project-createbom-multiple-purl branch September 11, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"project createBom" doesn't handle multiple purls
2 participants