-
Notifications
You must be signed in to change notification settings - Fork 20
Conversation
…ated objects where missing closes #106
this should be formulated as tag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You remove the file LicenseImporter.java
without a replacement and without mentioning it in the commit message or PR description.
Is it just unused?
Other than that the code looks good.
|
@MaximilianHuber, would you give an "Approved" review, please? |
ehem, suggestions how to test this are welcome - like I shall write a thrift client? I am testing for "everything behaves normal" then ... / looking at the integration test suite. |
An important thing to test is that importing license data through ComponentUploadPortlet still works. Given that the portlet is only available to admins, it's hard to test the permission checks without writing a thrift client or temporarily changing page permissions to try license import with a normal user. |
is it that assigned white list selection for a todo is not imported? (which could be fine, just mentioning it if this was intended) Import from export of another branch (Export Spreadsheet at Clearing Status) seems to work fine. The user was with role Please do not merge as I would like to have #352 before version jump. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested with license import export in various combinations
Added permission checks in license service for creating licenses and related objects where missing.
Deleted executable class
LicenseImporter.java
, which was designed to import license data from command line and has since been replaced by the functionality ofComponentUploadPortlet
closes #106
This PR introduces incompatible changes in Thrift API.
Increase the minor version after merging