test(datahandler): add assertion for couchdb test (lib-datahandler) #786
Conversation
|
I think we should remove this assertion based on the operating system error messages. |
maxhbr
force-pushed
the
maxhbr/fix/fix/attachment-blackholetest-assertion
branch
from
acd58ab
to
a399543
Compare
|
Sure, that is a problem, one could try to get the not-localized message or add other assertions to the type of the exception. |
| @@ -88,6 +87,7 @@ public String call() throws Exception { | |||
| } catch (ExecutionException e) { | |||
| Throwable futureException = e.getCause(); | |||
| assertThat(futureException, is(notNullValue())); | |||
| assertTrue(futureException instanceof SocketTimeoutException); | |||
There was a problem hiding this comment.
Maybe add SocketException or directly use IOException
There was a problem hiding this comment.
I want to avoid IOException, since it contains less information.
SocketException occurs on your system?
There was a problem hiding this comment.
"No route to host (Host unreachable)" should be NoRouteToHostException which extends the SocketException class
There was a problem hiding this comment.
Oh, now I understand. It depends on the routing of the network interface on the host, which exception gets thrown.
maxhbr
force-pushed
the
maxhbr/fix/fix/attachment-blackholetest-assertion
branch
from
a399543
to
7d3b407
Compare
This reverts commit 3b90fe7. Signed-off-by: Maximilian Huber <external.maximilian.huber2@bosch-si.com>
maxhbr
force-pushed
the
maxhbr/fix/fix/attachment-blackholetest-assertion
branch
from
7d3b407
to
5edc183
Compare
This reverts commit 3b90fe7 and fixes the internationalization bug.
related to #784