Skip to content

Commit

Permalink
refs #8431 - fix META-INF/services + travis check
Browse files Browse the repository at this point in the history
  • Loading branch information
frantuma committed Jul 20, 2018
1 parent aada2bc commit 5d0417f
Show file tree
Hide file tree
Showing 8 changed files with 62 additions and 10 deletions.
1 change: 1 addition & 0 deletions .gitignore
Expand Up @@ -26,4 +26,5 @@
hs_err_pid*

.idea
*.iml
target/
12 changes: 11 additions & 1 deletion .travis.yml
@@ -1,6 +1,16 @@
sudo: false
language: java
script: ./mvnw clean verify
script:
# fail fast
- set -e
# fail if templates/generators contain carriage return '\r'
- /bin/bash ./bin/utils/detect_carriage_return.sh
# fail if generators contain merge conflicts
- /bin/bash ./bin/utils/detect_merge_conflict.sh
# fail if generators contain tab '\t'
- /bin/bash ./bin/utils/detect_tab_in_java_class.sh
# run integration tests defined in maven pom.xml
- ./mvnw clean verify
jdk:
- openjdk8
after_success:
Expand Down
20 changes: 20 additions & 0 deletions bin/utils/detect_carriage_return.sh
@@ -0,0 +1,20 @@
#!/bin/bash


# grep for \r in the templates
grep -RUIl $'\r$' src/main/resources/*

if [ $? -ne 1 ]; then
echo "Templates contain carriage return '/r'. Please remove it and try again."
exit 1;
fi


# grep for \r in the generators
#grep -RUIl $'\r$' modules/swagger-codegen/src/main/java/io/swagger/codegen/v3/*.java
find src/main/java/ -type f -iname "*.java" -exec grep -RUIl $'\r$' {} \; | wc -l

if [ $? -ne 0 ]; then
echo "Generators contain carriage return '/r'. Please remove it and try again."
exit 1;
fi
9 changes: 9 additions & 0 deletions bin/utils/detect_merge_conflict.sh
@@ -0,0 +1,9 @@
#!/bin/bash

# grep for '<<<<<<< HEAD'
grep -RUIl '<<<<<<< HEAD' src

if [ $? -ne 1 ]; then
echo "src contain merge conflicts '<<<<<<< HEAD'. Please remove it and try again."
exit 1;
fi
12 changes: 12 additions & 0 deletions bin/utils/detect_tab_in_java_class.sh
@@ -0,0 +1,12 @@
#!/bin/bash

# grep for \t in the generators
RESULT=`find src/ -name "*.java" | xargs grep $'\t'`

echo -e "$RESULT"

if [ "$RESULT" != "" ]; then
echo "Java files contain tab '\\t'. Please remove it and try again."
exit 1;
fi

Expand Up @@ -1352,13 +1352,13 @@ public void addHandlebarHelpers(Handlebars handlebars) {
@Override
public void setLanguageArguments(List<CodegenArgument> languageArguments) {
if (languageArguments != null) {
if (!languageArguments.stream()
.anyMatch(codegenArgument -> CodegenConstants.USE_OAS2_OPTION.equalsIgnoreCase(codegenArgument.getOption()) && StringUtils.isNotBlank(codegenArgument.getValue()))) {
languageArguments.add(new CodegenArgument()
.option(CodegenConstants.USE_OAS2_OPTION)
.type("boolean")
.value(Boolean.FALSE.toString()));
}
if (!languageArguments.stream()
.anyMatch(codegenArgument -> CodegenConstants.USE_OAS2_OPTION.equalsIgnoreCase(codegenArgument.getOption()) && StringUtils.isNotBlank(codegenArgument.getValue()))) {
languageArguments.add(new CodegenArgument()
.option(CodegenConstants.USE_OAS2_OPTION)
.type("boolean")
.value(Boolean.FALSE.toString()));
}
}

super.setLanguageArguments(languageArguments);
Expand Down
Expand Up @@ -39,8 +39,8 @@ public String getName() {

@Override
public void processOpts() {
// Set the template dir first, before super.processOpts(), otherwise it is going to
// be set to /spec location.
// Set the template dir first, before super.processOpts(), otherwise it is going to
// be set to /spec location.
if (StringUtils.isBlank(templateDir)) {
if (StringUtils.isNotBlank(templateVersion)) {
embeddedTemplateDir = templateDir = String.format("%s/" + JAXRS_TEMPLATE_DIRECTORY_NAME + "/cxf-cdi", templateVersion);
Expand Down

0 comments on commit 5d0417f

Please sign in to comment.