[WIP] Add PHP client

[ackintosh]

With reference to java, work in progress now. 👀

TODO

• Fix build error
• Make PhpClientCodegen/AbstractPhpCodegen DRY
• etc...

[jmini]

First idea: you should merge master to your feature branch or rebase all your commit on top of master.

This is what I did locally to review your code.

[jmini]

DefaultCodegenConfig is not imported. add following line:

import io.swagger.codegen.languages.DefaultCodegenConfig;

[jmini]

Same here: DefaultCodegenConfig is not imported.

[jmini]

Package should be: io.swagger.codegen.languages.php

[jmini]

Package should be: io.swagger.codegen.languages.php

[jmini]

This produces a compile error by p.isListContainer.

Where did you get this file? AbstractPhpCodegen on the 3.0.0 branch in the swagger-codegen has no copile error. You should have took this as base.

[jmini]

This produces a compile error by p.isListContainer.

Where did you get this file? PhpClientCodegen on the 3.0.0 branch in the swagger-codegen has no copile error. You should have took this as base.

[jmini]

I hope you will manage to remove the compile errors. Do not hesitate to ask if you need something.

[jmini]

In order to help you, I have started a wiki page:
Swagger Codegen migration (swagger codegen generators repository)

[HugoMario]

@ackintosh do you mind if we merge your fork with a different branch, in order to help with TO-DO tasks? or can you please grant access to HugoMario user in your forked repo?

[ackintosh]

Sorry for late reply 💦
No, I don't. Please start your work in a different branch. ✨

[jmini]

I have automated a lot of the work that is requested to migrate the generators, this is no problem for me to migrate the PHP generator.

But I will not be able to evaluate the generated code and to confirm that it works as expected.

How do you want to proceed? Should I start something and you will test it?
@HugoMario any other idea?

[HugoMario]

thanks @ackintosh
@jmini sure, let me merge this into a new branch php_client_generator, so you can add your work there and i can later verify the generated code.

[jmini]

I have fetched the php_client_generator branch, but there is nothing more than on the master branch. I think you should merge ackintosh/php-client on your new branch.

What is the idea?
Should I create a pull request for the new php_client_generator branch, should I push directly on the php_client_generator branch (but I think that I need a permission for that).

I can also fetch ackintosh/php-client locally, push the changes I had described in this merge request and then open a new one.

---

@HugoMario: I would appreciate if you could review and merge my existing pull requests for the swagger-codegen-generators and swagger-codegen repositories.

There is a lot important stuff going on in order to improve Swagger v3.

[HugoMario]

@jmini i already merge this PR against php_client_generator branch. So the idea is that any change you want to make, you can do it pointing to this branch.