[qt5cpp] delete callback data allocated before signal emission #7840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stkrwork
suggested changes
Mar 15, 2018
| @@ -21,6 +22,19 @@ namespace {{this}} { | |||
| QString stringValue(qint64 value); | |||
| QString stringValue(bool value); | |||
|
|
|||
| template <typename ObjPtrT> | |||
There was a problem hiding this comment.
maybe move this class to its own file
There was a problem hiding this comment.
Do you want to suggest a more appropriate class name also?
I don't know if ObjLaterDeleter is appropriate.
There was a problem hiding this comment.
OK, I came up with object wrapper which is what it is..., :)
…lback_data # Conflicts: # modules/swagger-codegen/src/main/java/io/swagger/codegen/languages/Qt5CPPGenerator.java # samples/client/petstore/qt5cpp/PetStore/PetStore.pro
stkrwork
suggested changes
Mar 17, 2018
| {{/cppNamespaceDeclarations}} | ||
|
|
||
| template <typename ObjectPtrT> | ||
| class QObjectWrapper : public QObject { |
There was a problem hiding this comment.
Maybe also add the prefix to this class name as well
stkrwork
approved these changes
Mar 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
Before emitting the signals declared in the API class when the callback from HTTP Worker object is received, there is memory allocation being made which is unknown to user code.
This PR adds a wrapper to any memory allocation being done and schedule deleteLater so that once the signal callback has been invoked, the object can be scheduled to be deleted.
Ideal case would be all memory allocation done by the generated code will be deallocated inside it, and user allocated memory will be done on user code.
Tests
There is a limitation with the current PetStore tests because when the callback is received the loop is exited which prevents deleteLater from running. So the PetStore still have the memory Leak visible.
@stkrwork @fvarose @ravinikam