-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #1419 from shockey/ft/1311-autocomplete-performanc…
…e-switching Implement 100ms cutoff point for Live Autocomplete
- Loading branch information
Showing
4 changed files
with
48 additions
and
4 deletions.
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
export function wrapCompleters(completers, cutoff = 100) { | ||
let isLiveCompletionDisabled = false | ||
let lastSpeeds = [] | ||
let isPerformant = () => lastSpeeds.every(speed => speed < cutoff) | ||
|
||
if(cutoff === 0 || cutoff === "0") { | ||
// never disable live autocomplete | ||
return completers | ||
} | ||
|
||
return completers.map((completer, i) => { | ||
let ori = completer.getCompletions | ||
completer.getCompletions = function(editor, session, pos, prefix, callback) { | ||
let startTime = Date.now() | ||
ori(editor, session, pos, prefix, (...args) => { | ||
let msElapsed = Date.now() - startTime | ||
lastSpeeds[i] = msElapsed | ||
|
||
if(isLiveCompletionDisabled && isPerformant()) { | ||
console.warn("Manual autocomplete was performant - re-enabling live autocomplete") | ||
editor.setOptions({ | ||
enableLiveAutocompletion: true | ||
}) | ||
isLiveCompletionDisabled = false | ||
} | ||
|
||
if(msElapsed > cutoff && editor.getOption("enableLiveAutocompletion")) { | ||
console.warn("Live autocomplete is slow - disabling it") | ||
editor.setOptions({ | ||
enableLiveAutocompletion: false | ||
}) | ||
isLiveCompletionDisabled = true | ||
} | ||
|
||
callback(...args) | ||
}) | ||
} | ||
return completer | ||
}) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters