Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BasePath ignored when schema and host aren't set #1091

Closed
ghost opened this issue Jun 20, 2017 · 2 comments
Closed

BasePath ignored when schema and host aren't set #1091

ghost opened this issue Jun 20, 2017 · 2 comments
Labels
P2 type: bug version: 3.x

Comments

@ghost
Copy link

ghost commented Jun 20, 2017 •
edited by ghost
Loading

Currently if a spec doesn't have a schema and host set then the basepath is not used when executing an operation.

The source responsible for this can be found here. https://github.com/swagger-api/swagger-js/blob/master/src/execute.js#L212-L227

I have a fix on my own fork where I pretty much do the same thing that line 224 does but with the computedPath. I will create a pull request hopefully later this week.
TheLocust3 added a commit to TheLocust3/swagger-js that referenced this issue Jul 14, 2017
@TheLocust3
Default to computedPath if schema or host is not set. Fixes swagger-a…
9ad8a48 
…pi#1091
@TheLocust3 TheLocust3 mentioned this issue Jul 14, 2017
Closed
@ereOn
Copy link

ereOn commented Jul 17, 2017

Any news on this ?

@shockey shockey closed this as completed Nov 3, 2017
@shockey
Copy link
Contributor

shockey commented Nov 3, 2017

Fixed by #1166!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 type: bug version: 3.x
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@webron @ereOn @shockey