Conversation
@jsdevel this looks good, any concerns? |
// convert .{format} to .json, make path params happy | ||
var fullPath = spec.path.replace(self.formatString, self.jsonSuffix).replace(/\/{/g, "/:").replace(/\}/g, ""); | ||
// convert .{format} to .json, make path params happy, remove trailing slash | ||
var fullPath = spec.path.replace(self.formatString, self.jsonSuffix) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mgutz even though this is just formatting, I would prefer to see it in a separate commit.
@fehguy thanks for the include! Ideally I'd like to see express leveraged to the max, but in this case I'm not sure how else we would go about it. @mgutz can you think of any other way we could accomplish this without changing swagger? Overall, I feel these changes provide a lot of value and I'm also thankful that @mgutz provided tests! |
+1 on added value, definitely a must have. |
Could really use this for route specific middleware... |
Hi folks, we've been pretty busy with the swagger 2.0 release, which was Monday. Getting back to this shortly |
Any progress? ;) |
Is this going in soon? |
Not soon, we are discussing the architecture for the port to swagger spec 2.0 (per #180). At the same time looking at what changes an updated design (such as apigee-127, swagger-n) provide, and if we should work on those projects. |
+1 are you guys not accepting pull requests? |
I have achieved this using the excellent middleware-flow module. I'm pretty sure it achieves the same thing. |
Closing as #207 will completely replace the implementation in this project. |
This allows
action
to be an array of middleware instead of a single handler. For example, we have middleware to do oauth2 scope checks, role checks etc.