This repository has been archived by the owner on Sep 14, 2022. It is now read-only.
allow actions to have an array of middleware which express calls before calling action #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
+1 |
1 similar comment
|
+1 |
| @@ -332,7 +332,11 @@ function resourceListing(req, res) { | |||
|
|
|||
| // Adds a method to the api along with a spec. If the spec fails to validate, it won't be added | |||
|
|
|||
| function addMethod(app, callback, spec) { | |||
| function addMethod(app, handler) { | |||
There was a problem hiding this comment.
I think this is going to cause backward compatibility problems so Wordnik might require you to bump the major version of the package. Alternatively, maybe we need to add a new method and deprecate this one.
|
see #132 |
|
+1 |
|
Closing as #207 will completely replace the implementation in this project. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't know if this is something ya'll will support or merge, but I wanted to highlight it even so in case you have a recommended alternative solution. I often have multiple middleware functions in my Express routes (example). swagger-node-express handles the case of one common middleware being authentication, but not multiple. Of course, I could use
async.waterfallin theactionproperty - which I started to do, but which got unwieldy. This PR might be a decent/clean approach.