This repository has been archived by the owner on Sep 14, 2022. It is now read-only.
npm@3 support: fix swagger-editor dir path. Fixes #351 #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW tests are failing on master, not due to this change. |
|
Hi, yes, there was a dependency change which has caused master to start failing. Will get that resolved before merging your PR. |
|
Just curious, has development stopped on swagger-node? |
|
@badsyntax we do our best, but sometimes things get delayed beyond what we wish them too. Apologies for the late response here. For the sake of completeness, can you please rebase your PR? We fixed the build and that should make the build of your PR to fix as well. |
at15
added a commit
to at15/swagger-node
that referenced
this pull request
Apr 20, 2016
Fixes swagger-api#351. Original PR swagger-api#352
|
@fehguy @badsyntax I guess this pr can be closed, since #369 is already merged. |
|
@at15 a polite request for rebase then a merge of this PR would have been the better approach. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #351