Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 2046] NPE in OpenAPIV3Parser.read(String, List<AuthorizationValue>, ParseOptions) #2047

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

garydgregory
Copy link
Contributor

@garydgregory garydgregory commented Jan 22, 2024

Issue: #2046
PR: #2047

java.lang.NullPointerException: Cannot invoke "java.util.List.iterator()" because the return value of "io.swagger.v3.parser.core.models.SwaggerParseResult.getMessages()" is null
	at io.swagger.v3.parser.OpenAPIV3Parser.read(OpenAPIV3Parser.java:125)
	at ...
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)

The test is convoluted because the real test would be in the main parser module plus a dependency on this module, which one cannot do due to circularity, but, note that the NPE and fix are "real" and have been tested in production on my end.

List<AuthorizationValue>, ParseOptions)
@garydgregory garydgregory changed the title Fix Issue 2046 [Issue 2046] NPE in OpenAPIV3Parser.read(String, List<AuthorizationValue>, ParseOptions) Jan 23, 2024
@gracekarina gracekarina self-assigned this Jan 30, 2024
@gracekarina
Copy link
Contributor

thank you

@gracekarina gracekarina merged commit 7d6bad8 into swagger-api:master Jan 30, 2024
6 checks passed
@garydgregory
Copy link
Contributor Author

@gracekarina
Thank you 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants