Skip to content
This repository has been archived by the owner on Sep 14, 2022. It is now read-only.

Support Play 2.5 #66

Closed
andersha opened this issue Mar 9, 2016 · 10 comments
Closed

Support Play 2.5 #66

andersha opened this issue Mar 9, 2016 · 10 comments

Comments

@andersha
Copy link
Contributor

andersha commented Mar 9, 2016

Is there a plan for supporting play 2.5?

@poornerd
Copy link

poornerd commented Mar 9, 2016

I am also VERY interested

@andersha
Copy link
Contributor Author

andersha commented Mar 9, 2016

I checked out the code, made a play-2.5 directory by duplicating 2.4, changed all dependencies with regards to play 2.5 and recompiled. I got an error due to a change in the play api:

[error] .../play-2.5/swagger-play2/app/controllers/ApiHelpController.scala:207: 
play.api.http.HttpEntity.type does not take parameters
[error]       body = HttpEntity(jsonBytes)

If no-one else is working on this, I can set off some time to look at it.

@andersha
Copy link
Contributor Author

I've looked into it, and the code is hit by changes in Streams, ref https://www.playframework.com/documentation/2.5.0/StreamsMigration25

I'm not proficient enough in Scala to choose the best path here.

frne pushed a commit to frne/swagger-play that referenced this issue Mar 10, 2016
@frne frne mentioned this issue Mar 10, 2016
@frne
Copy link

frne commented Mar 10, 2016

Fixed in #68 using Akka streams as suggested in the migration guide.

@ChintaMallikarjunaRao
Copy link

can someone help me on steps to integrate swagger API (with version details)for play 2.5.0 and scala 2.11.7, i am trying out,i can able to get the swagger version by hitting api-docs.json, swagger.json,but i am not able to implement with my controllers.

@frne
Copy link

frne commented May 13, 2016

@ChintaMallikarjunaRao AFAIK not working yet. See #68

@cipacda
Copy link
Contributor

cipacda commented Jun 28, 2016

Do we have an ETA for this?

@cipacda
Copy link
Contributor

cipacda commented Jun 29, 2016

I have made this pull request which works for me, for anyone who looks for something like this:

#88

@sadowski
Copy link

+1 for this, if anyone is still looking at it.

@fehguy
Copy link
Contributor

fehguy commented Oct 29, 2016

Per #97 this has been completed.

@fehguy fehguy closed this as completed Oct 29, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants