Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use filename disposition parameter in downloads #1991

Closed
davehagler opened this issue Feb 24, 2016 · 2 comments
Closed

Use filename disposition parameter in downloads #1991

davehagler opened this issue Feb 24, 2016 · 2 comments
Milestone

Comments

@davehagler
Copy link
Contributor

Currently when an api returns "content-type": "application/octet-stream" and "content-disposition": "attachment", a filename is generated for the download that looks like

[content type]:[url parameters]:generated

In cases where the api returns a filename= disposition parameter, this value could be used when saving the downloaded file.

For example if this header is sent in the response

"content-disposition": "attachment; filename=my_file.txt"

Then the downloaded file would be called "my_file.txt"

fehguy added a commit that referenced this issue Feb 25, 2016
Fix Issue #1991 filename parameter in content disposition response he…
@webron
Copy link
Contributor

webron commented Feb 25, 2016

Fixed by #1993.

@webron webron closed this as completed Feb 25, 2016
vincent-zurczak referenced this issue in roboconf/swagger-ui Aug 19, 2016
Fix Issue #1991 filename parameter in content disposition response he…
@fehguy fehguy added this to the v2.2.1 milestone Aug 23, 2016
@patelneelj
Copy link

patelneelj commented Oct 26, 2021

@davehagler @webron
I am using swagger-UI version3.25.0still I am getting this issue.
Is anyone encounter the same issue still?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants