Added extraction of quoted file name from content disposition header #4035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shockey
suggested changes
Jan 6, 2018
# Conflicts: # test/core/utils.js
shockey
approved these changes
Jan 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small bug fix, added ability to extract quoted file name from Content-Disposition header.
Description
Extended fix for Issue #1991, added extraction of quoted file name that is present in case when file name contains special characters like " ".
Motivation and Context
When header contains quoted file name, it is presented on UI quoted as well ("some file.ext"), when downloading file from UI on windows the " characters are replaced by "_" character and it does change file name and extension (first and last char in filename) after saving file.