Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 18 support #8126

Closed
jabacrack opened this issue Jul 26, 2022 · 6 comments
Closed

React 18 support #8126

jabacrack opened this issue Jul 26, 2022 · 6 comments

Comments

@jabacrack
Copy link

Some packages in my application require React 18, but I cannot use it , because react-debounce-input from swagger-ui dependecies support only v17

Found: react@18.2.0
npm ERR! node_modules/react
npm ERR!   react@"18.2.0" from the root project
npm ERR!   peer react@"^16.3.0 || ^17.0.0 || ^18.0.0" from ag-grid-react@28.0.0
npm ERR!   node_modules/ag-grid-react
npm ERR!     ag-grid-react@"28.0.0" from the root project
npm ERR!   18 more (highcharts-react-official, rc-align, rc-motion, ...)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^15.3.0 || ^16.0.0 || ^17.0.0" from react-debounce-input@3.2.4
npm ERR! node_modules/react-debounce-input
npm ERR!   react-debounce-input@"=3.2.4" from swagger-ui-react@4.13.0
npm ERR!   node_modules/swagger-ui-react
npm ERR!     swagger-ui-react@"4.13.0" from the root project

Do you plan support React 18 in near future (and when) or workaround exist for this problem?

@jabacrack
Copy link
Author

After updating react-debounce-input to version 3.3.0 in release 4.13.2 Swagger work fine with React 18.2.0

@jenniferabowd
Copy link
Contributor

@jabacrack does this require any action? If not, mind closing the issue? I'm down to attempt to resolve it if this does require action.

@jackkav
Copy link
Contributor

jackkav commented Oct 21, 2022

@jenniferabowd upgrading these 3 libraries will help your downstream dependants to avoid having to include these overrides in their package.json, I opened a PR over here #8244

  "overrides": {
    "swagger-ui-react": {
      "react-inspector": "6.0.1",
      "react-copy-to-clipboard": "5.1.0"
    }
  },

@hadrien-toma
Copy link

I am also blocked because of the version of React, does any one know what we have to do to support React 18? I can make a PR for that if someone guides me a little bit 😊✨

@sybernatus
Copy link

🙏

@sybernatus sybernatus mentioned this issue Feb 23, 2023
17 tasks
char0n added a commit that referenced this issue Jun 6, 2023
This support is fully backward complatible with
React@17.

Refs #8126
char0n added a commit that referenced this issue Jun 6, 2023
sybernatus pushed a commit to sybernatus/swagger-ui that referenced this issue Jun 7, 2023
This support is fully backward complatible with
React@17.

Refs swagger-api#8126
char0n added a commit that referenced this issue Dec 20, 2023
Any React version matching this semver is supported: >= 16.8 < 19

Refs #8126
Refs #8414
@char0n char0n self-assigned this Dec 20, 2023
@char0n
Copy link
Member

char0n commented Dec 20, 2023

Addressed by #9435

@char0n char0n closed this as completed Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants