Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for React@18 in backward compatible way #9435

Merged
merged 7 commits into from
Dec 20, 2023

Conversation

char0n
Copy link
Member

@char0n char0n commented Dec 20, 2023

Refs #8126
Refs #8414

Description

Adds React@18 support in backward compatible way. When React@17 or React@16 used with npm overrides or yarn resolutions SwaggerUI will compensate.

Motivation and Context

Integrator needs to use latest version of React. Without SwaggerUI supporting React@18, integrators are left bundling two versions of React at the same time.

How Has This Been Tested?

All the existing tests are passing.

Screenshots (if appropriate):

image

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@char0n char0n self-assigned this Dec 20, 2023
@char0n char0n added type: enhancement dependencies Pull requests that update a dependency file version: 5.x labels Dec 20, 2023
@char0n char0n mentioned this pull request Dec 20, 2023
17 tasks
@char0n
Copy link
Member Author

char0n commented Dec 20, 2023

Attribution needs to be added to @sybernatus during squash + merge:

Co-authored-by: Jérôme GARCIA

@char0n char0n merged commit 98b5309 into master Dec 20, 2023
6 checks passed
@char0n char0n mentioned this pull request Dec 20, 2023
@sybernatus
Copy link

Thanks @char0n for your help ending this 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file type: enhancement version: 5.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants