Prevent loading resources from third party CDN #4598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove usage of Google Fonts to avoid any data protection issue. Using a CDN will leak data to a third party that can be simply avoided by using system fonts instead. Furthermore the usage of CDNs can cause legal issues in EU countries.
|
I'd hate to see our pretty fonts go away, but I do recognize the weight of potential GDPR issues. As was discussed downstream, we could look at making this a configuration option (perhaps something generic like @webron, thoughts? |
|
The used fonts are licensed as following:
See: https://fonts.google.com/attribution Therefore the alternative of using the Google Fonts API is to bundle the fonts directly with the build of Swagger and add it to the distribution. Then no external resources are needed and still the pretty fonts can be used. |
shockey
approved these changes
Jul 6, 2018
|
thanks @markuspoerschke! |
papandreou
added a commit
to papandreou/swagger-ui
that referenced
this pull request
Aug 28, 2018
17 tasks
papandreou
added a commit
to papandreou/swagger-ui-express
that referenced
this pull request
Aug 28, 2018
swagger-ui 3.17.3 included this PR, which stopped using Google Web Fonts: swagger-api/swagger-ui#4598 ... So it's no longer necessary to load the Google Web Fonts CSS anymore.
papandreou
added a commit
to papandreou/swagger-ui-express
that referenced
this pull request
Aug 28, 2018
swagger-ui 3.17.3 included this PR, which stopped using Google Web Fonts: swagger-api/swagger-ui#4598 ... So it's no longer necessary to load the Google Web Fonts CSS.
shockey
pushed a commit
that referenced
this pull request
Sep 6, 2018
manicki
added a commit
to manicki/hapi-swaggered-ui
that referenced
this pull request
Apr 12, 2019
Following the change in the swagger-ui: swagger-api/swagger-ui#4598
bvanderlaan
pushed a commit
to bvanderlaan/swagger-ui-restify
that referenced
this pull request
May 3, 2019
swagger-ui 3.17.3 included this PR, which stopped using Google Web Fonts: swagger-api/swagger-ui#4598 ... So it's no longer necessary to load the Google Web Fonts CSS. (cherry picked from commit ead61ab) Conflicts: indexTemplate.html
JuanSW18
pushed a commit
to Digital-Paw/digital-paw-swagger-ui
that referenced
this pull request
Aug 23, 2024
…ger-api#4598) Remove usage of Google Fonts to avoid any data protection issue. Using a CDN will leak data to a third party that can be simply avoided by using system fonts instead. Furthermore the usage of CDNs can cause legal issues in EU countries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Checklist
My PR contains...
src/is unmodified: changes to documentation, CI, metadata, etc.)package.json)My changes...
Documentation
Automated tests