Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: enforce commit message conventions #6577

Merged
merged 2 commits into from Oct 29, 2020
Merged

chore: enforce commit message conventions #6577

merged 2 commits into from Oct 29, 2020

Conversation

tim-lai
Copy link
Contributor

@tim-lai tim-lai commented Oct 29, 2020

Description

Introduces enforcement of commit message policy describe in organization
wide CONTRIBUTING.md file (https://github.com/swagger-api/.github/blob/master/CONTRIBUTING.md).

Also add a link to CONTRIBUTING.md to README.md

Motivation and Context

Improve Status Quo and enforce agreed convention.

How Has This Been Tested?

Screenshots (if appropriate):

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@tim-lai tim-lai merged commit 9b0ff32 into swagger-api:master Oct 29, 2020
Pentusha pushed a commit to Pentusha/swagger-ui that referenced this pull request Nov 8, 2020
@IvanLarinAtSpark
Merge tag 'v3.36.2' of github.com:swagger-api/swagger-ui
db25226 
Jenkins Git plugin tagging with v3.36.2

* tag 'v3.36.2' of github.com:swagger-api/swagger-ui: (337 commits)
  chore(release): cut the v3.36.2 release
  fix: duplicate labels in Servers UI (swagger-api#6568)
  fix: externalDocs url for tags when using swagger v2.0 (swagger-api#6579)
  fix(schema example): xml gen should follow json gen behavior (swagger-api#6555)
  fix(cypress): oas3-request-body-required flakineess (swagger-api#6583)
  housekeeping(dev-deps): webpack-stats-plugin@1.0.2 (swagger-api#6576)
  chore: enforce commit message conventions (swagger-api#6577)
  chore(release): cut the v3.36.1 release
  housekeeping(deps): swagger-client@3.12.0 (swagger-api#6575)
  housekeeping(dev-deps): nightwatch@1.5.1
  fix(cypress): oas3-multiple-media-types flakiness (swagger-api#6571)
  housekeeping(dev-deps): file-loader@6.2.0
  housekeeping(dev-deps): mini-css-extract-plugin@1.2.1
  housekeeping(dev-deps): cypress@5.5.0
  ci(GA): add lint-errors step (swagger-api#6564)
  ci(GA): add test:artifact job (swagger-api#6562)
  ci(GA): add release job step (swagger-api#6558)
  ci(GA): use github actions as CI (swagger-api#6557)
  housekeeping(dev-deps): mini-css-extract-plugin@1.2.0
  housekeeping(dev-deps): @jest/globals@26.6.1
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@tim-lai