fixed externalDocs url for tags when using swagger v2.0 #6579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dalbrx-forcam Merged! Thanks for the catch and contribution! |
Pentusha
pushed a commit
to Pentusha/swagger-ui
that referenced
this pull request
Nov 8, 2020
Jenkins Git plugin tagging with v3.36.2 * tag 'v3.36.2' of github.com:swagger-api/swagger-ui: (337 commits) chore(release): cut the v3.36.2 release fix: duplicate labels in Servers UI (swagger-api#6568) fix: externalDocs url for tags when using swagger v2.0 (swagger-api#6579) fix(schema example): xml gen should follow json gen behavior (swagger-api#6555) fix(cypress): oas3-request-body-required flakineess (swagger-api#6583) housekeeping(dev-deps): webpack-stats-plugin@1.0.2 (swagger-api#6576) chore: enforce commit message conventions (swagger-api#6577) chore(release): cut the v3.36.1 release housekeeping(deps): swagger-client@3.12.0 (swagger-api#6575) housekeeping(dev-deps): nightwatch@1.5.1 fix(cypress): oas3-multiple-media-types flakiness (swagger-api#6571) housekeeping(dev-deps): file-loader@6.2.0 housekeeping(dev-deps): mini-css-extract-plugin@1.2.1 housekeeping(dev-deps): cypress@5.5.0 ci(GA): add lint-errors step (swagger-api#6564) ci(GA): add test:artifact job (swagger-api#6562) ci(GA): add release job step (swagger-api#6558) ci(GA): use github actions as CI (swagger-api#6557) housekeeping(dev-deps): mini-css-extract-plugin@1.2.0 housekeeping(dev-deps): @jest/globals@26.6.1 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make sure that the externalDocs URL is shown for tags when using swagger 2.0
Motivation and Context
After d9f5691#diff-3dbef565aa1c233034c876486e56cb578991acc34dd62eba31b2c5fa3ac25544 the URL of the externalDOCs is not shown at all when using swagger 2.0
How Has This Been Tested?
Manually tested
Added jest test
Screenshots (if appropriate):
Screenshot showing the problem:
Checklist
My PR contains...
src/is unmodified: changes to documentation, CI, metadata, etc.)package.json)My changes...
Documentation
Automated tests