Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(swagger-ui): wrap whole div in CopyToClipboard component to fix button behaviour #9097

Closed

Conversation

damian-polewski-sb
Copy link
Contributor

Description

This PR does the following:

  • In CopyToClipboardBtn wraps the whole div in CopyToClipboard wrapping component

Motivation and Context

This change solves an issue with copy to clipboard button not copying the operation name in the operation summary.
Fixes #9094

How Has This Been Tested?

I manually tested copy to clipboard button to confirm that it works correctly after applying the changes. I also run the unit test to confirm that everything is working as intended.

Screenshots (if appropriate):

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@char0n
Copy link
Member

char0n commented Aug 1, 2023

This PR is superseded by #9106. Reasoning is explained inside the PR and in #9094 (comment).

@char0n char0n closed this Aug 1, 2023
@char0n char0n deleted the bug/fix-copy-to-clipboard-button-behaviour branch February 14, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: "Copy" button not working
4 participants