Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for @x- attributes on security definition #971

Merged
merged 3 commits into from Aug 11, 2021
Merged

Added support for @x- attributes on security definition #971

merged 3 commits into from Aug 11, 2021

Conversation

pmorelli92
Copy link
Contributor

@pmorelli92 pmorelli92 commented Aug 9, 2021

Relates to issue #970.

Before this PR the only @x- attribute supported on the security definition was the hardcoded x-tokenName. After this PR all the @x- attributes that are parsed in the same block than the security definition are going to be added.

Added extra logic for not adding twice the @x- attributes that are present on the security definition and removed the hardcoded case scenario for token name as well.

@codecov
Copy link

codecov bot commented Aug 9, 2021

Codecov Report

Merging #971 (32bcbba) into master (505d4f1) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #971      +/-   ##
==========================================
+ Coverage   88.12%   88.15%   +0.03%     
==========================================
  Files           8        8              
  Lines        1869     1874       +5     
==========================================
+ Hits         1647     1652       +5     
  Misses        127      127              
  Partials       95       95              
Impacted Files Coverage Δ
parser.go 86.81% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 505d4f1...32bcbba. Read the comment docs.

@pmorelli92
Copy link
Contributor Author

@sdghchj @ubogdan Hi guys! Sorry to bother you with the tag, but I would like to know if you can give some love to this PR. Unfortunately, at the company I am working, I have a deadline soon and I would need to know if I can use this dependency or not. Sorry again

@ubogdan
Copy link
Contributor

ubogdan commented Aug 11, 2021

@pmorelli92 I need a working CI build with additional tests added in order to see both "Travis" and "Codecov" passing in order to take a decision on it.

Would you please push another small update so I can make a clue where we are at?

@pmorelli92
Copy link
Contributor Author

Done! @ubogdan

Copy link
Contributor

@ubogdan ubogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ubogdan ubogdan merged commit fd504eb into swaggo:master Aug 11, 2021
@ubogdan
Copy link
Contributor

ubogdan commented Aug 11, 2021

@pmorelli92 Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants