Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allways init response header map at first. #1066

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

tanopanta
Copy link
Contributor

@tanopanta tanopanta commented Nov 29, 2021

Describe the PR
fix: allways init response header map at first.

Relation issue
closes #1065

@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #1066 (9bf6735) into master (305a5cf) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 9bf6735 differs from pull request most recent head 34ca095. Consider uploading reports for the commit 34ca095 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1066   +/-   ##
=======================================
  Coverage   94.42%   94.43%           
=======================================
  Files           9        9           
  Lines        2261     2264    +3     
=======================================
+ Hits         2135     2138    +3     
  Misses         66       66           
  Partials       60       60           
Impacted Files Coverage Δ
operation.go 95.90% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 305a5cf...34ca095. Read the comment docs.

@ubogdan
Copy link
Contributor

ubogdan commented Nov 29, 2021

@tanopanta swag has quite low code coverage. It looks like this part was not covered and it was looking fine to me according to existing unit tests.

@ubogdan
Copy link
Contributor

ubogdan commented Nov 29, 2021

@tanopanta Thanks for your contribution.

Copy link
Contributor

@ubogdan ubogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ubogdan ubogdan merged commit 231fa42 into swaggo:master Nov 29, 2021
@tanopanta tanopanta deleted the fix-header-gen-only-all branch November 30, 2021 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when generating headers with only "all". (after v1.7.6)
2 participants