Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrongly shared schema by fields #1389

merged 3 commits into from Nov 22, 2022

fix: wrongly shared schema by fields #1389

merged 3 commits into from Nov 22, 2022


Copy link

@sdghchj sdghchj commented Nov 21, 2022

Describe the PR
If there are more than two fields with the same redefined type which especially based on a primitive type, they will share a schema in fault. If one of them modified the schema, another will be affected.

fix : every field gets a copy of the schema unless the schema is a ref schema, and then complete it with field properties.

Relation issue

Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Base: 95.60% // Head: 95.55% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (3d7eb8a) compared to base (e6723fe).
Patch coverage: 85.71% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1389      +/-   ##
- Coverage   95.60%   95.55%   -0.05%     
  Files          16       16              
  Lines        3023     3035      +12     
+ Hits         2890     2900      +10     
- Misses         74       75       +1     
- Partials       59       60       +1     
Impacted Files Coverage Δ
schema.go 97.64% <77.77%> (-2.36%) ⬇️
parser.go 94.01% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sdghchj sdghchj merged commit 8117f4c into master Nov 22, 2022
8 of 10 checks passed
@sdghchj sdghchj deleted the fix-1342 branch November 22, 2022 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants