Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2: Update Makefile #1560

Merged
merged 8 commits into from
Apr 19, 2023
Merged

V2: Update Makefile #1560

merged 8 commits into from
Apr 19, 2023

Conversation

Nerzal
Copy link
Contributor

@Nerzal Nerzal commented Apr 18, 2023

Describe the PR
Merged master branch into v2 branch.
Also integrated the new delimiter feature into the v3 generator

tzxdtc and others added 8 commits April 11, 2023 10:43
* Add template action delimiter cli flag

* Add delims to generator config and template

Also adds tests using the "quote" test as a base. This has to have a
custom Instance name or it will clash with the "quotes" one and panic
since it will have registered two "swagger" instances in the package
test.

* Add testdata for custom delim flags

Based on the "quote" testdata.

* Add delims to the spec, with tests.

Make sure we don't add delims if they are empty. This shouldn't be
possible, but might as well be safe.

* Go mod tidy and sum update

* Make the CLI experience a bit cleaner

* Revert go.mod and sum

* Update readme
Signed-off-by: sdghchj <sdghchj@qq.com>
@Nerzal Nerzal changed the title V2: Integrate fixes and features form master branch V2: Update Makefile Apr 18, 2023
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Patch coverage: 93.75% and project coverage change: +1.85 🎉

Comparison is base (21247c7) 77.67% compared to head (36e4376) 79.52%.

❗ Current head 36e4376 differs from pull request most recent head 68be2f7. Consider uploading reports for the commit 68be2f7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##               v2    #1560      +/-   ##
==========================================
+ Coverage   77.67%   79.52%   +1.85%     
==========================================
  Files          21       21              
  Lines        5528     5549      +21     
==========================================
+ Hits         4294     4413     +119     
+ Misses       1048      962      -86     
+ Partials      186      174      -12     
Impacted Files Coverage Δ
format/format.go 92.30% <ø> (ø)
operation.go 94.52% <ø> (ø)
gen/gen.go 71.47% <90.00%> (+0.78%) ⬆️
field_parser.go 96.44% <100.00%> (+0.04%) ⬆️
field_parserv3.go 75.70% <100.00%> (+31.62%) ⬆️
operationv3.go 83.65% <100.00%> (+0.04%) ⬆️
package.go 72.81% <100.00%> (-0.27%) ⬇️
spec.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ubogdan
Copy link
Contributor

ubogdan commented Apr 19, 2023

@Nerzal as a member, you can create a branch in swaggo/swag repository. You don't need to use a forked repo any more.

@Nerzal
Copy link
Contributor Author

Nerzal commented Apr 19, 2023

Yeah, that is also definitely going to prevent problems with pushing tags to the wrong repo. I'll use this from now on

@Nerzal Nerzal merged commit ff9485a into swaggo:v2 Apr 19, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants