Feat: multi-arch docker image #1756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngehrsitz
approved these changes
Feb 9, 2024
There was a problem hiding this comment.
👍 But I would incorporate some further improvements tnaroska#1
With that you can also test in your fork if you create a tag in the form of v*
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1756 +/- ##
=======================================
Coverage 83.40% 83.40%
=======================================
Files 16 16
Lines 3881 3881
=======================================
Hits 3237 3237
Misses 545 545
Partials 99 99 ☔ View full report in Codecov by Sentry. |
|
Update and resolve the conflicts, please. |
- adapt Dockerfile to support cross-compilation depending on TARGETARCH and TARGETOS variables see https://www.docker.com/blog/faster-multi-platform-builds-dockerfile-cross-compilation-guide/ - set target platforms for docker/build-push-action
@sdghchj done |
|
@tnaroska Thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Fix #1755 by enabling go cross-compilation in Dockerfile and setting multiple target architectures in docker/build-push-action.
Relation issue
#1755 - Create multi-arch docker image for amd64/arm64
Additional context
Validated the Dockerfile change by building a multi-arch image locally.
I have no way to test the change in github worklfow though.Thanks to @ngehrsitz, changes to github workflow could be validated on this fork repo, too.