Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix go lint error #335

Merged
merged 1 commit into from Mar 21, 2019
Merged

fix go lint error #335

merged 1 commit into from Mar 21, 2019

Conversation

pei0804
Copy link
Member

@pei0804 pei0804 commented Mar 21, 2019

Describe the PR
fix for golint error

@pei0804
Copy link
Member Author

pei0804 commented Mar 21, 2019

@easonlin404 review plz.

@codecov-io
Copy link

codecov-io commented Mar 21, 2019

Codecov Report

Merging #335 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #335   +/-   ##
=======================================
  Coverage   87.02%   87.02%           
=======================================
  Files           7        7           
  Lines        1279     1279           
=======================================
  Hits         1113     1113           
  Misses        103      103           
  Partials       63       63

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 622e072...def7b39. Read the comment docs.

Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@easonlin404 easonlin404 merged commit 889705a into master Mar 21, 2019
@easonlin404 easonlin404 deleted the fix-golint-error branch March 21, 2019 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants