Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamic schemes bugfix #450

Merged
merged 8 commits into from
Jul 11, 2019
Merged

dynamic schemes bugfix #450

merged 8 commits into from
Jul 11, 2019

Conversation

ubogdan
Copy link
Contributor

@ubogdan ubogdan commented Jul 11, 2019

Describe the PR
bugfix: can't set schemes in annotation anymore

Relation issue
issue #449

Additional context
None.

@codecov-io
Copy link

codecov-io commented Jul 11, 2019

Codecov Report

Merging #450 into master will decrease coverage by 0.1%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #450      +/-   ##
==========================================
- Coverage   83.37%   83.27%   -0.11%     
==========================================
  Files           7        7              
  Lines        1456     1459       +3     
==========================================
+ Hits         1214     1215       +1     
- Misses        137      138       +1     
- Partials      105      106       +1
Impacted Files Coverage Δ
gen/gen.go 75.86% <50%> (-2.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f5a434...9927bc6. Read the comment docs.

Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@easonlin404
Copy link
Member

@ubogdan you can reference https://help.github.com/en/articles/configuring-a-remote-for-a-fork next PR. And maybe can add a test cases that set schemes in annotation and programatically in the same time.

@easonlin404 easonlin404 merged commit 6de832a into swaggo:master Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants