Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code coverage in operation.go #456

Merged
merged 2 commits into from
Jul 17, 2019
Merged

Fix code coverage in operation.go #456

merged 2 commits into from
Jul 17, 2019

Conversation

ubogdan
Copy link
Contributor

@ubogdan ubogdan commented Jul 16, 2019

Describe the PR
Fix code coverage in operation.go

Relation issue
None

Additional context
None.

Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please help resolve conflicts.

@codecov-io
Copy link

codecov-io commented Jul 16, 2019

Codecov Report

Merging #456 into master will increase coverage by 2.45%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #456      +/-   ##
==========================================
+ Coverage   83.36%   85.82%   +2.45%     
==========================================
  Files           7        7              
  Lines        1467     1467              
==========================================
+ Hits         1223     1259      +36     
+ Misses        138      119      -19     
+ Partials      106       89      -17
Impacted Files Coverage Δ
operation.go 95.07% <0%> (+8.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4642ffd...a274c39. Read the comment docs.

@ubogdan ubogdan requested review from easonlin404, a team and pei0804 July 16, 2019 09:23
@ubogdan
Copy link
Contributor Author

ubogdan commented Jul 16, 2019

Conflicts resolved.

@ubogdan
Copy link
Contributor Author

ubogdan commented Jul 16, 2019

@easonlin404 Can you review this please.

@ubogdan ubogdan assigned easonlin404 and unassigned ubogdan and codecov-io Jul 16, 2019
Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@easonlin404 easonlin404 merged commit bd1235d into swaggo:master Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants