Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: embeded struct not parsed #463

Merged
merged 1 commit into from
Jul 19, 2019
Merged

feat: embeded struct not parsed #463

merged 1 commit into from
Jul 19, 2019

Conversation

ubogdan
Copy link
Contributor

@ubogdan ubogdan commented Jul 18, 2019

Describe the PR
Nested Struct (Promoted fields) aren't showing properly in the documentation.

Relation issue
#376

Additional context
None.

@ubogdan ubogdan requested a review from easonlin404 July 18, 2019 12:07
@codecov-io
Copy link

Codecov Report

Merging #463 into master will decrease coverage by 0.14%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #463      +/-   ##
=========================================
- Coverage   85.94%   85.8%   -0.15%     
=========================================
  Files           7       7              
  Lines        1494    1500       +6     
=========================================
+ Hits         1284    1287       +3     
- Misses        120     122       +2     
- Partials       90      91       +1
Impacted Files Coverage Δ
parser.go 80.85% <50%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72f30f8...80eec33. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented Jul 18, 2019

Codecov Report

Merging #463 into master will decrease coverage by 0.14%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #463      +/-   ##
=========================================
- Coverage   85.94%   85.8%   -0.15%     
=========================================
  Files           7       7              
  Lines        1494    1500       +6     
=========================================
+ Hits         1284    1287       +3     
- Misses        120     122       +2     
- Partials       90      91       +1
Impacted Files Coverage Δ
parser.go 80.85% <50%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72f30f8...80eec33. Read the comment docs.

Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@easonlin404 easonlin404 changed the title feature: embeded struct not parsed feat: embeded struct not parsed Jul 19, 2019
@easonlin404 easonlin404 merged commit be88a64 into master Jul 19, 2019
@easonlin404 easonlin404 deleted the fix-issue-376 branch July 19, 2019 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants