Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(gen.go): improve code coverage #468

Merged
merged 3 commits into from
Jul 20, 2019
Merged

refactor(gen.go): improve code coverage #468

merged 3 commits into from
Jul 20, 2019

Conversation

ubogdan
Copy link
Contributor

@ubogdan ubogdan commented Jul 19, 2019

Describe the PR
Fix issue #466
Fix issue #466
Refactor gen/gen.go , improve gen.go coverage

Relation issue
#466, #466

Additional context
None.

Fix issue #466
Refactor gen/gen.go , improve gen.go coverage
@codecov-io
Copy link

codecov-io commented Jul 19, 2019

Codecov Report

Merging #468 into master will increase coverage by 0.8%.
The diff coverage is 97.43%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #468     +/-   ##
========================================
+ Coverage    85.8%   86.6%   +0.8%     
========================================
  Files           7       7             
  Lines        1500    1560     +60     
========================================
+ Hits         1287    1351     +64     
+ Misses        122     120      -2     
+ Partials       91      89      -2
Impacted Files Coverage Δ
parser.go 81.11% <100%> (+0.26%) ⬆️
gen/gen.go 89.65% <97.29%> (+13.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be88a64...9e6bb6a. Read the comment docs.

@ubogdan ubogdan requested a review from easonlin404 July 19, 2019 22:02
@easonlin404 easonlin404 changed the title Fix issue #466 refactor(gen.go): improve code coverage Jul 20, 2019
Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave comment, rest LGTM.

@easonlin404 easonlin404 merged commit 67075e4 into swaggo:master Jul 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants